chore(client): introduce extensible YAML config in Go #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
changed the title
fortuna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the config parsing from Typescript to Go. The new implementation supports an extensible YAML format that is backwards-compatible with the two formats we supported (legacy SS JSON and SS URL).
The migration of parsing from Typescript to Go forced the functions to be changed to async, which cascades on a number of changes up the stack all the way to main. Constructors had to be replaced with async factory functions and web components had to have async updates. I also had to hunt unhandled promise rejections at run time, since Typescript is unable to detect that.
TODO: